2019-11-14T00:02:54 *** cherylhjli1 has quit IRC (Quit: Leaving.) 2019-11-14T00:23:02 *** jhernandez has joined #fluid-work 2019-11-14T00:26:52 *** jhernandez has quit IRC (Client Quit) 2019-11-14T01:17:08 *** danayo_ has joined #fluid-work 2019-11-14T02:37:50 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-14T03:36:47 *** danayo_ has joined #fluid-work 2019-11-14T03:42:30 *** alanharnum has quit IRC (Quit: Connection closed for inactivity) 2019-11-14T04:07:55 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-14T04:25:34 *** danayo_ has joined #fluid-work 2019-11-14T04:47:46 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-14T07:31:50 *** yanachkov__ has joined #fluid-work 2019-11-14T08:46:39 *** yanachkov__ has quit IRC (Read error: Connection reset by peer) 2019-11-14T08:47:22 *** kris_HA has joined #fluid-work 2019-11-14T11:11:14 *** kris_HA has quit IRC (Ping timeout: 240 seconds) 2019-11-14T11:48:04 *** kris_HA has joined #fluid-work 2019-11-14T12:04:40 *** jhernandez has joined #fluid-work 2019-11-14T12:28:34 *** jhernandez has quit IRC (Quit: jhernandez) 2019-11-14T12:51:15 *** bryan_ has quit IRC (*.net *.split) 2019-11-14T12:53:59 *** bryan_ has joined #fluid-work 2019-11-14T13:39:00 *** michelled has joined #fluid-work 2019-11-14T13:39:00 *** michelled has quit IRC (Client Quit) 2019-11-14T13:40:19 *** michelled has joined #fluid-work 2019-11-14T13:43:22 *** cindyli has joined #fluid-work 2019-11-14T13:43:33 Morning, cindyli :) 2019-11-14T13:43:39 *** Bosmon2 is now known as Bosmon 2019-11-14T13:44:39 morning, Bosmon 2019-11-14T13:53:16 Bosmon: in relation to fluid-6426 I notice that there are many places where we are prefetching the sub panel options... I'm thinking that rather than doing that repeatedly, to store it in a member on the composite panel and just refer to the prefetched values from there. Is there any issue with doing that? 2019-11-14T13:53:54 Justin_o - what do you mean by "prefetching"? 2019-11-14T13:55:11 Bosmon: https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L298-L306 2019-11-14T13:55:59 Justin_o - so terrible 2019-11-14T13:56:02 I'd just leave it : P 2019-11-14T13:56:09 okay 2019-11-14T13:56:11 haha 2019-11-14T13:56:25 I guess it won't be worse that it already is, if we just leave it 2019-11-14T13:58:20 We shouldn't really spend more than the bare minimum of effort on this code to get us over the hump 2019-11-14T13:58:23 It is beyond saving : P 2019-11-14T13:58:41 it's hard to argue with that 2019-11-14T13:58:47 *** simonjb has joined #fluid-work 2019-11-14T14:11:00 *** cherylhjli has joined #fluid-work 2019-11-14T14:21:30 Bosmon: hmm.. I think I've run into another problem. So the rebasing of the selectors from the sub panel needs access to the sub panel's container selector. https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L516 2019-11-14T14:21:44 *** danielcho has joined #fluid-work 2019-11-14T14:21:55 that way we can scope the selectors inside of the sub panels container, so that we don't accidentally break out and effect other panels. 2019-11-14T14:22:26 however, if I access the container property from the components block, it may be an IoC expression.. 2019-11-14T14:22:53 if I access the composite panel's selectors, they seem to already evaluate and don't accept the merge from the grade I'm synthesizing 2019-11-14T14:22:56 Bosmon: ^ 2019-11-14T14:23:41 Justin_o - how is the situation different from where we executed this via onCreate? 2019-11-14T14:24:53 Justin_o - Ok, I guess I can see what is happening :( 2019-11-14T14:25:25 All the selectors are munged together inside options.selectors in the composite panel's options? 2019-11-14T14:25:48 And we need to consume some of these whilst at the same time we are trying to contribute to them? 2019-11-14T14:27:59 Bosmon: yep that's basically the situation 2019-11-14T14:28:04 Justin_o - ok 2019-11-14T14:28:11 we need to know the selectors used for the containers of the sub panels 2019-11-14T14:28:43 What you can try is rather than trying to consume the selectors via {that}.options.selectors, to force the framework to just evaluate the ones you need 2019-11-14T14:29:05 via selectorIWant = fluid.getForComponent(that, ["options", "selectors", name]) 2019-11-14T14:30:19 It's true that if you send "{that}.options.selectors" in as a direct argument to the expander it will consider it fully evaluated and not attempt to consider the contents of the expander once it arrives 2019-11-14T14:31:06 If this doesn't work I think we will probably just have to give up on this idea of immutable options until we can axe the prefs framework : P 2019-11-14T14:31:13 Bosmon: ah.. could I just pass in "{that}" and access that.options.selectors internally.. would that be safe? 2019-11-14T14:31:27 Justin_o - no, no good 2019-11-14T14:31:30 Because you will see it unevaluated 2019-11-14T14:31:43 But yes, you will need to pass in {that} otherwise you can't get anything done 2019-11-14T14:32:39 Bosmon: also we have the components block passed into the function. https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L403 2019-11-14T14:32:56 *** jhung has joined #fluid-work 2019-11-14T14:32:59 would it be possible and safer to expand the container property from each component? 2019-11-14T14:33:38 Justin_o - could do that, but a bit tricky because of the special status of "container" in the old framework 2019-11-14T14:34:10 And it will only amount to the same thing in the end since the framework will have to do the same work of special expansion 2019-11-14T14:34:23 In any case, a call to fluid.getForComponent is hugely preferable to a call to fluid.expandOptions 2019-11-14T14:34:32 The former just schedules work that was always going to be done anyway 2019-11-14T14:34:50 Bosmon: okay, I'll give that a go 2019-11-14T14:34:53 thanks 2019-11-14T14:37:03 *** avtar has joined #fluid-work 2019-11-14T14:38:28 Bosmon: I seem to be getting the same problem 2019-11-14T14:38:36 :( 2019-11-14T14:39:36 Bosmon: is there a way to add this with an IoC expression? 2019-11-14T14:39:42 or maybe an expander? 2019-11-14T14:39:43 Justin_o - ok, so here's a final idea 2019-11-14T14:39:59 Rather than adding one big expander, try to add a bunch of little expanders, one for each selector you want to generate 2019-11-14T14:40:09 And supply it exactly the arguments it needs as IoC expressions 2019-11-14T14:40:17 okay, good.. I was just thinking of that too 2019-11-14T14:41:26 Bosmon: so I'm thinking in my synthesized grade, I'll create a selectors block that has an expander for each injected selector that takes in the composite panel's selector as an argument 2019-11-14T14:43:46 Justin_o - yes, that seems right 2019-11-14T14:47:08 *** alanharnum has joined #fluid-work 2019-11-14T15:34:40 Wow, Justin_o 2019-11-14T15:34:46 A pull? : P 2019-11-14T15:35:01 :) you saw that fast.. I just pushed it up 2019-11-14T15:35:03 *** jhernandez has joined #fluid-work 2019-11-14T15:35:40 Bosmon: the approach using expanders seems to have worked.. hopefully it addresses all the issues you have with relation to options modification and other new framework things 2019-11-14T15:38:40 *** simonjb has quit IRC () 2019-11-14T15:46:30 Justin_o - amazing work 2019-11-14T15:46:37 We have dodged that bullet by the skin of our teeth : P 2019-11-14T15:48:48 haha, definitely. it's also amazing how small the change ended up being. 2019-11-14T15:57:02 Bosmon: I've had those builds failing randomly on me with the last few PRs I think 2019-11-14T15:57:52 Bosmon: also just noticed that GitHub has these actions things https://github.com/features/actions 2019-11-14T15:58:04 I wonder if they would be useful for replacing Jenkins at some point 2019-11-14T15:58:35 *** kris_HA has quit IRC (Ping timeout: 265 seconds) 2019-11-14T16:08:38 *** simonjb has joined #fluid-work 2019-11-14T16:29:28 *** clown has joined #fluid-work 2019-11-14T16:31:36 *** danayo_ has joined #fluid-work 2019-11-14T16:40:50 Justin_o I've done a fair bit of experimentation with GitHub Actions. They are quite powerful and (as of yesterday) are now in a stable release. 2019-11-14T16:41:21 greatislander: cool... how are they to work with? 2019-11-14T16:43:55 *** cindyli1 has joined #fluid-work 2019-11-14T16:43:55 *** cindyli has quit IRC (Read error: Connection reset by peer) 2019-11-14T16:46:25 Very comfortable for me (coming from mostly using Travis and CircleCI in the past) 2019-11-14T16:47:29 I have them set up for basic linting on the Platform Coop pattern library: https://github.com/platform-coop-toolkit/pinecone/blob/dev/.github/workflows/nodejs.yml 2019-11-14T16:47:50 Would be happy to walk through that file with you/others at some point 2019-11-14T16:59:24 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-14T17:15:21 *** jhung is now known as jhung_away 2019-11-14T17:15:49 *** colinclark has joined #fluid-work 2019-11-14T17:25:31 greatislander: thanks, a tour through would be nice at some point. Although I don't really know much about our current system. I think alanharnum and avtar might be the ones that know about that. 2019-11-14T17:25:40 cool cool 2019-11-14T17:29:35 *** clown has quit IRC (Ping timeout: 268 seconds) 2019-11-14T17:30:08 *** clown has joined #fluid-work 2019-11-14T17:32:26 *** jhung_away is now known as jhung 2019-11-14T17:41:12 *** danayo_ has joined #fluid-work 2019-11-14T17:44:57 *** avtar has quit IRC (Ping timeout: 240 seconds) 2019-11-14T17:54:50 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-14T18:06:32 *** danayo_ has joined #fluid-work 2019-11-14T18:20:08 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-14T18:21:08 *** javjarfer[m] has quit IRC (Write error: Connection reset by peer) 2019-11-14T19:35:01 *** colinclark has quit IRC (Quit: colinclark) 2019-11-14T19:42:43 Justin_o: How are you getting along with virtualbox? Have you found any solution to crossing your fingers yet? Also, I've always assumed our vagrant scripts were tied to virtualbox, but I'm wondering if it's possible to swap in another vm host like vmware or parallels 2019-11-14T19:58:55 *** avtar has joined #fluid-work 2019-11-14T20:13:43 *** cherylhjli has quit IRC (Quit: Leaving.) 2019-11-14T20:15:49 *** cindyli1 has quit IRC (Quit: Leaving.) 2019-11-14T20:27:47 *** avtar has quit IRC (Quit: Quit) 2019-11-14T20:29:21 *** cindyli has joined #fluid-work 2019-11-14T20:33:30 *** colinclark has joined #fluid-work 2019-11-14T20:46:07 *** cindyli has quit IRC (Quit: Leaving.) 2019-11-14T20:47:54 *** avtar has joined #fluid-work 2019-11-14T20:59:25 *** cherylhjli has joined #fluid-work 2019-11-14T21:04:06 *** cindyli has joined #fluid-work 2019-11-14T21:20:24 Hey there Justin_o .... astonishingly your pull passed completely 2019-11-14T21:20:38 It seems like that was really our last site of options modification in the framework 2019-11-14T21:20:41 Great job, dude :) 2019-11-14T21:29:52 wowza 2019-11-14T21:33:19 *** jhung has quit IRC (Quit: Leaving) 2019-11-14T21:38:09 *** the-t-in-rtf has quit IRC (Quit: Leaving.) 2019-11-14T21:40:13 *** cindyli has quit IRC (Quit: Leaving.) 2019-11-14T21:45:11 *** cherylhjli1 has joined #fluid-work 2019-11-14T21:47:07 *** cherylhjli has quit IRC (Ping timeout: 250 seconds) 2019-11-14T21:49:58 *** jhernandez has quit IRC (Quit: jhernandez) 2019-11-14T22:03:23 *** clown has quit IRC (Quit: Leaving.) 2019-11-14T22:12:31 *** cindyli has joined #fluid-work 2019-11-14T22:13:08 *** cindyli has quit IRC (Client Quit) 2019-11-14T22:42:54 *** danielcho has left #fluid-work 2019-11-14T22:54:46 *** simonjb has quit IRC () 2019-11-14T23:13:16 *** cherylhjli1 has quit IRC (Quit: Leaving.) 2019-11-14T23:15:13 *** colinclark has quit IRC (Quit: colinclark) 2019-11-14T23:25:42 *** avtar has quit IRC (Quit: Quit) 2019-11-14T23:40:45 *** michelled has quit IRC (Quit: Leaving.) 2019-11-14T23:46:54 *** alanharnum has quit IRC (Quit: Connection closed for inactivity)