2019-11-14T00:02:54  *** cherylhjli1 <cherylhjli1!~Adium@205.211.168.104> has quit IRC (Quit: Leaving.)
2019-11-14T00:23:02  *** jhernandez <jhernandez!~jhernande@2a02:a03f:3e72:c800:afce:ea01:d362:3594> has joined #fluid-work
2019-11-14T00:26:52  *** jhernandez <jhernandez!~jhernande@2a02:a03f:3e72:c800:afce:ea01:d362:3594> has quit IRC (Client Quit)
2019-11-14T01:17:08  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has joined #fluid-work
2019-11-14T02:37:50  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has quit IRC (Quit: danayo_)
2019-11-14T03:36:47  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has joined #fluid-work
2019-11-14T03:42:30  *** alanharnum <alanharnum!uid363993@gateway/web/irccloud.com/x-ylveezlzsjlblahl> has quit IRC (Quit: Connection closed for inactivity)
2019-11-14T04:07:55  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has quit IRC (Quit: danayo_)
2019-11-14T04:25:34  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has joined #fluid-work
2019-11-14T04:47:46  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has quit IRC (Quit: danayo_)
2019-11-14T07:31:50  *** yanachkov__ <yanachkov__!~yanachkov@185.97.75.80> has joined #fluid-work
2019-11-14T08:46:39  *** yanachkov__ <yanachkov__!~yanachkov@185.97.75.80> has quit IRC (Read error: Connection reset by peer)
2019-11-14T08:47:22  *** kris_HA <kris_HA!~yanachkov@185.97.75.80> has joined #fluid-work
2019-11-14T11:11:14  *** kris_HA <kris_HA!~yanachkov@185.97.75.80> has quit IRC (Ping timeout: 240 seconds)
2019-11-14T11:48:04  *** kris_HA <kris_HA!~yanachkov@185.97.75.80> has joined #fluid-work
2019-11-14T12:04:40  *** jhernandez <jhernandez!~jhernande@2a02:a03f:3e72:c800:afce:ea01:d362:3594> has joined #fluid-work
2019-11-14T12:28:34  *** jhernandez <jhernandez!~jhernande@2a02:a03f:3e72:c800:afce:ea01:d362:3594> has quit IRC (Quit: jhernandez)
2019-11-14T12:51:15  *** bryan_ <bryan_!sid334924@gateway/web/irccloud.com/x-fyzqlrgkfaxacfno> has quit IRC (*.net *.split)
2019-11-14T12:53:59  *** bryan_ <bryan_!sid334924@gateway/web/irccloud.com/x-fyzqlrgkfaxacfno> has joined #fluid-work
2019-11-14T13:39:00  *** michelled <michelled!~Adium@135-23-85-27.cpe.pppoe.ca> has joined #fluid-work
2019-11-14T13:39:00  *** michelled <michelled!~Adium@135-23-85-27.cpe.pppoe.ca> has quit IRC (Client Quit)
2019-11-14T13:40:19  *** michelled <michelled!~Adium@135-23-85-27.cpe.pppoe.ca> has joined #fluid-work
2019-11-14T13:43:22  *** cindyli <cindyli!~Adium@198.52.178.16> has joined #fluid-work
2019-11-14T13:43:33  <Bosmon2> Morning, cindyli :)
2019-11-14T13:43:39  *** Bosmon2 is now known as Bosmon
2019-11-14T13:44:39  <cindyli> morning, Bosmon
2019-11-14T13:53:16  <Justin_o> Bosmon: in relation to fluid-6426 I notice that there are many places where we are prefetching the sub panel options... I'm thinking that rather than doing that repeatedly, to store it in a member on the composite panel and just refer to the prefetched values from there. Is there any issue with doing that?
2019-11-14T13:53:54  <Bosmon> Justin_o - what do you mean by "prefetching"?
2019-11-14T13:55:11  <Justin_o> Bosmon: https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L298-L306
2019-11-14T13:55:59  <Bosmon> Justin_o - so terrible
2019-11-14T13:56:02  <Bosmon> I'd just leave it : P
2019-11-14T13:56:09  <Justin_o> okay
2019-11-14T13:56:11  <Justin_o> haha
2019-11-14T13:56:25  <Justin_o> I guess it won't be worse that it already is, if we just leave it
2019-11-14T13:58:20  <Bosmon> We shouldn't really spend more than the bare minimum of effort on this code to get us over the hump
2019-11-14T13:58:23  <Bosmon> It is beyond saving : P
2019-11-14T13:58:41  <Justin_o> it's hard to argue with that
2019-11-14T13:58:47  *** simonjb <simonjb!~simonjb@198.178.118.18> has joined #fluid-work
2019-11-14T14:11:00  *** cherylhjli <cherylhjli!~Adium@142.118.118.222> has joined #fluid-work
2019-11-14T14:21:30  <Justin_o> Bosmon: hmm.. I think I've run into another problem. So the rebasing of the selectors from the sub panel needs access to the sub panel's container selector. https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L516
2019-11-14T14:21:44  *** danielcho <danielcho!~Adium@hmtnon1497w-130-02-65-95-64-90.dsl.bell.ca> has joined #fluid-work
2019-11-14T14:21:55  <Justin_o> that way we can scope the selectors inside of the sub panels container, so that we don't accidentally break out and effect other panels.
2019-11-14T14:22:26  <Justin_o> however, if I access the container property from the components block, it may be an IoC expression..
2019-11-14T14:22:53  <Justin_o> if I access the composite panel's selectors, they seem to already evaluate and don't accept the merge from the grade I'm synthesizing
2019-11-14T14:22:56  <Justin_o> Bosmon: ^
2019-11-14T14:23:41  <Bosmon> Justin_o - how is the situation different from where we executed this via onCreate?
2019-11-14T14:24:53  <Bosmon> Justin_o - Ok, I guess I can see what is happening :(
2019-11-14T14:25:25  <Bosmon> All the selectors are munged together inside options.selectors in the composite panel's options?
2019-11-14T14:25:48  <Bosmon> And we need to consume some of these whilst at the same time we are trying to contribute to them?
2019-11-14T14:27:59  <Justin_o> Bosmon: yep that's basically the situation
2019-11-14T14:28:04  <Bosmon> Justin_o - ok
2019-11-14T14:28:11  <Justin_o> we need to know the selectors used for the containers of the sub panels
2019-11-14T14:28:43  <Bosmon> What you can try is rather than trying to consume the selectors via {that}.options.selectors, to force the framework to just evaluate the ones you need
2019-11-14T14:29:05  <Bosmon> via selectorIWant = fluid.getForComponent(that, ["options", "selectors", name])
2019-11-14T14:30:19  <Bosmon> It's true that if you send "{that}.options.selectors" in as a direct argument to the expander it will consider it fully evaluated and not attempt to consider the contents of the expander once it arrives
2019-11-14T14:31:06  <Bosmon> If this doesn't work I think we will probably just have to give up on this idea of immutable options until we can axe the prefs framework : P
2019-11-14T14:31:13  <Justin_o> Bosmon: ah.. could I just pass in "{that}" and access that.options.selectors internally.. would that be safe?
2019-11-14T14:31:27  <Bosmon> Justin_o - no, no good
2019-11-14T14:31:30  <Bosmon> Because you will see it unevaluated
2019-11-14T14:31:43  <Bosmon> But yes, you will need to pass in {that} otherwise you can't get anything done
2019-11-14T14:32:39  <Justin_o> Bosmon: also we have the components block passed into the function. https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L403
2019-11-14T14:32:56  *** jhung <jhung!~jhung@CPE18e829ac96f5-CMa84e3f431590.cpe.net.cable.rogers.com> has joined #fluid-work
2019-11-14T14:32:59  <Justin_o> would it be possible and safer to expand the container property from each component?
2019-11-14T14:33:38  <Bosmon> Justin_o - could do that, but a bit tricky because of the special status of "container" in the old framework
2019-11-14T14:34:10  <Bosmon> And it will only amount to the same thing in the end since the framework will have to do the same work of special expansion
2019-11-14T14:34:23  <Bosmon> In any case, a call to fluid.getForComponent is hugely preferable to a call to fluid.expandOptions
2019-11-14T14:34:32  <Bosmon> The former just schedules work that was always going to be done anyway
2019-11-14T14:34:50  <Justin_o> Bosmon: okay, I'll give that a go
2019-11-14T14:34:53  <Justin_o> thanks
2019-11-14T14:37:03  *** avtar <avtar!~avtar@ip-24-50-164-78.user.start.ca> has joined #fluid-work
2019-11-14T14:38:28  <Justin_o> Bosmon: I seem to be getting the same problem
2019-11-14T14:38:36  <Bosmon> :(
2019-11-14T14:39:36  <Justin_o> Bosmon: is there a way to add this with an IoC expression?
2019-11-14T14:39:42  <Justin_o> or maybe an expander?
2019-11-14T14:39:43  <Bosmon> Justin_o - ok, so here's a final idea
2019-11-14T14:39:59  <Bosmon> Rather than adding one big expander, try to add a bunch of little expanders, one for each selector you want to generate
2019-11-14T14:40:09  <Bosmon> And supply it exactly the arguments it needs as IoC expressions
2019-11-14T14:40:17  <Justin_o> okay, good.. I was just thinking of that too
2019-11-14T14:41:26  <Justin_o> Bosmon: so I'm thinking in my synthesized grade, I'll create a selectors block that has an expander for each injected selector that takes in the composite panel's selector as an argument
2019-11-14T14:43:46  <Bosmon> Justin_o - yes, that seems right
2019-11-14T14:47:08  *** alanharnum <alanharnum!uid363993@gateway/web/irccloud.com/x-yuvawblgvegtuxql> has joined #fluid-work
2019-11-14T15:34:40  <Bosmon> Wow, Justin_o
2019-11-14T15:34:46  <Bosmon> A pull? : P
2019-11-14T15:35:01  <Justin_o> :) you saw that fast.. I just pushed it up
2019-11-14T15:35:03  *** jhernandez <jhernandez!~jhernande@2a02:a03f:3e72:c800:afce:ea01:d362:3594> has joined #fluid-work
2019-11-14T15:35:40  <Justin_o> Bosmon: the approach using expanders seems to have worked.. hopefully it addresses all the issues you have with relation to options modification and other new framework things
2019-11-14T15:38:40  *** simonjb <simonjb!~simonjb@198.178.118.18> has quit IRC ()
2019-11-14T15:46:30  <Bosmon> Justin_o - amazing work
2019-11-14T15:46:37  <Bosmon> We have dodged that bullet by the skin of our teeth : P
2019-11-14T15:48:48  <Justin_o> haha, definitely. it's also amazing how small the change ended up being.
2019-11-14T15:57:02  <Justin_o> Bosmon: I've had those builds failing randomly on me with the last few PRs I think
2019-11-14T15:57:52  <Justin_o> Bosmon: also just noticed that GitHub has these actions things https://github.com/features/actions
2019-11-14T15:58:04  <Justin_o> I wonder if they would be useful for replacing Jenkins at some point
2019-11-14T15:58:35  *** kris_HA <kris_HA!~yanachkov@185.97.75.80> has quit IRC (Ping timeout: 265 seconds)
2019-11-14T16:08:38  *** simonjb <simonjb!~simonjb@205.211.168.103> has joined #fluid-work
2019-11-14T16:29:28  *** clown <clown!clown@nat/ocadu/x-ztocmmiqwyroqiob> has joined #fluid-work
2019-11-14T16:31:36  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has joined #fluid-work
2019-11-14T16:40:50  <greatislander> Justin_o I've done a fair bit of experimentation with GitHub Actions. They are quite powerful and (as of yesterday) are now in a stable release.
2019-11-14T16:41:21  <Justin_o> greatislander: cool... how are they to work with?
2019-11-14T16:43:55  *** cindyli1 <cindyli1!~Adium@198.52.178.16> has joined #fluid-work
2019-11-14T16:43:55  *** cindyli <cindyli!~Adium@198.52.178.16> has quit IRC (Read error: Connection reset by peer)
2019-11-14T16:46:25  <greatislander> Very comfortable for me (coming from mostly using Travis and CircleCI in the past)
2019-11-14T16:47:29  <greatislander> I have them set up for basic linting on the Platform Coop pattern library: https://github.com/platform-coop-toolkit/pinecone/blob/dev/.github/workflows/nodejs.yml
2019-11-14T16:47:50  <greatislander> Would be happy to walk through that file with you/others at some point
2019-11-14T16:59:24  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has quit IRC (Quit: danayo_)
2019-11-14T17:15:21  *** jhung is now known as jhung_away
2019-11-14T17:15:49  *** colinclark <colinclark!~colinclar@192-0-158-138.cpe.teksavvy.com> has joined #fluid-work
2019-11-14T17:25:31  <Justin_o> greatislander: thanks, a tour through would be nice at some point. Although I don't really know much about our current system. I think alanharnum and avtar might be the ones that know about that.
2019-11-14T17:25:40  <greatislander> cool cool
2019-11-14T17:29:35  *** clown <clown!clown@nat/ocadu/x-ztocmmiqwyroqiob> has quit IRC (Ping timeout: 268 seconds)
2019-11-14T17:30:08  *** clown <clown!clown@nat/ocadu/x-jejczwclzkghiehl> has joined #fluid-work
2019-11-14T17:32:26  *** jhung_away is now known as jhung
2019-11-14T17:41:12  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has joined #fluid-work
2019-11-14T17:44:57  *** avtar <avtar!~avtar@ip-24-50-164-78.user.start.ca> has quit IRC (Ping timeout: 240 seconds)
2019-11-14T17:54:50  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has quit IRC (Quit: danayo_)
2019-11-14T18:06:32  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has joined #fluid-work
2019-11-14T18:20:08  *** danayo_ <danayo_!~danayo@S0106f81d0f5cda43.vc.shawcable.net> has quit IRC (Quit: danayo_)
2019-11-14T18:21:08  *** javjarfer[m] <javjarfer[m]!javjarferm@gateway/shell/matrix.org/x-hwneibbqcqdkdxjw> has quit IRC (Write error: Connection reset by peer)
2019-11-14T19:35:01  *** colinclark <colinclark!~colinclar@192-0-158-138.cpe.teksavvy.com> has quit IRC (Quit: colinclark)
2019-11-14T19:42:43  <sgithens> Justin_o: How are you getting along with virtualbox? Have you found any solution to crossing your fingers yet? Also, I've always assumed our vagrant scripts were tied to virtualbox, but I'm wondering if it's possible to swap in another vm host like vmware or parallels
2019-11-14T19:58:55  *** avtar <avtar!~avtar@ip-24-50-164-78.user.start.ca> has joined #fluid-work
2019-11-14T20:13:43  *** cherylhjli <cherylhjli!~Adium@142.118.118.222> has quit IRC (Quit: Leaving.)
2019-11-14T20:15:49  *** cindyli1 <cindyli1!~Adium@198.52.178.16> has quit IRC (Quit: Leaving.)
2019-11-14T20:27:47  *** avtar <avtar!~avtar@ip-24-50-164-78.user.start.ca> has quit IRC (Quit: Quit)
2019-11-14T20:29:21  *** cindyli <cindyli!~Adium@198.52.178.16> has joined #fluid-work
2019-11-14T20:33:30  *** colinclark <colinclark!~colinclar@205.211.168.102> has joined #fluid-work
2019-11-14T20:46:07  *** cindyli <cindyli!~Adium@198.52.178.16> has quit IRC (Quit: Leaving.)
2019-11-14T20:47:54  *** avtar <avtar!~avtar@ip-24-50-164-78.user.start.ca> has joined #fluid-work
2019-11-14T20:59:25  *** cherylhjli <cherylhjli!Adium@nat/ocadu/x-mvvkibqybnkoosiy> has joined #fluid-work
2019-11-14T21:04:06  *** cindyli <cindyli!~Adium@198.52.178.16> has joined #fluid-work
2019-11-14T21:20:24  <Bosmon> Hey there Justin_o .... astonishingly your pull passed completely
2019-11-14T21:20:38  <Bosmon> It seems like that was really our last site of options modification in the framework
2019-11-14T21:20:41  <Bosmon> Great job, dude :)
2019-11-14T21:29:52  <colinclark> wowza
2019-11-14T21:33:19  *** jhung <jhung!~jhung@CPE18e829ac96f5-CMa84e3f431590.cpe.net.cable.rogers.com> has quit IRC (Quit: Leaving)
2019-11-14T21:38:09  *** the-t-in-rtf <the-t-in-rtf!~Adium@2a02:a210:2142:3480:dc85:2167:ae28:8a60> has quit IRC (Quit: Leaving.)
2019-11-14T21:40:13  *** cindyli <cindyli!~Adium@198.52.178.16> has quit IRC (Quit: Leaving.)
2019-11-14T21:45:11  *** cherylhjli1 <cherylhjli1!~Adium@205.211.168.105> has joined #fluid-work
2019-11-14T21:47:07  *** cherylhjli <cherylhjli!Adium@nat/ocadu/x-mvvkibqybnkoosiy> has quit IRC (Ping timeout: 250 seconds)
2019-11-14T21:49:58  *** jhernandez <jhernandez!~jhernande@2a02:a03f:3e72:c800:afce:ea01:d362:3594> has quit IRC (Quit: jhernandez)
2019-11-14T22:03:23  *** clown <clown!clown@nat/ocadu/x-jejczwclzkghiehl> has quit IRC (Quit: Leaving.)
2019-11-14T22:12:31  *** cindyli <cindyli!~Adium@198.52.178.16> has joined #fluid-work
2019-11-14T22:13:08  *** cindyli <cindyli!~Adium@198.52.178.16> has quit IRC (Client Quit)
2019-11-14T22:42:54  *** danielcho <danielcho!~Adium@hmtnon1497w-130-02-65-95-64-90.dsl.bell.ca> has left #fluid-work
2019-11-14T22:54:46  *** simonjb <simonjb!~simonjb@205.211.168.103> has quit IRC ()
2019-11-14T23:13:16  *** cherylhjli1 <cherylhjli1!~Adium@205.211.168.105> has quit IRC (Quit: Leaving.)
2019-11-14T23:15:13  *** colinclark <colinclark!~colinclar@205.211.168.102> has quit IRC (Quit: colinclark)
2019-11-14T23:25:42  *** avtar <avtar!~avtar@ip-24-50-164-78.user.start.ca> has quit IRC (Quit: Quit)
2019-11-14T23:40:45  *** michelled <michelled!~Adium@135-23-85-27.cpe.pppoe.ca> has quit IRC (Quit: Leaving.)
2019-11-14T23:46:54  *** alanharnum <alanharnum!uid363993@gateway/web/irccloud.com/x-yuvawblgvegtuxql> has quit IRC (Quit: Connection closed for inactivity)