2019-11-11T00:23:53 *** yzen has joined #fluid-work 2019-11-11T00:29:14 *** Bosmon3 has quit IRC (Ping timeout: 240 seconds) 2019-11-11T00:44:53 *** yzen has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…) 2019-11-11T06:05:22 *** the-t-in-rtf has joined #fluid-work 2019-11-11T07:13:48 *** the-t-in-rtf has quit IRC (Quit: Leaving.) 2019-11-11T08:19:31 *** the-t-in-rtf has joined #fluid-work 2019-11-11T10:19:32 *** the-t-in-rtf has quit IRC (Quit: Leaving.) 2019-11-11T10:19:42 *** the-t-in-rtf has joined #fluid-work 2019-11-11T10:19:56 *** the-t-in-rtf has quit IRC (Client Quit) 2019-11-11T10:20:04 *** the-t-in-rtf has joined #fluid-work 2019-11-11T10:20:35 *** the-t-in-rtf has quit IRC (Client Quit) 2019-11-11T10:23:50 *** Bosmon3 has joined #fluid-work 2019-11-11T10:42:23 *** Bosmon3 has quit IRC (Ping timeout: 245 seconds) 2019-11-11T10:56:32 *** yanachkov__ has joined #fluid-work 2019-11-11T11:01:04 *** Bosmon3 has joined #fluid-work 2019-11-11T11:14:20 *** Bosmon3 has quit IRC (Ping timeout: 276 seconds) 2019-11-11T12:49:35 *** the-t-in-rtf has joined #fluid-work 2019-11-11T13:18:02 *** Bosmon3 has joined #fluid-work 2019-11-11T13:40:34 *** cindyli has joined #fluid-work 2019-11-11T13:48:24 *** jhung has joined #fluid-work 2019-11-11T13:51:26 *** Bosmon3 has quit IRC (Ping timeout: 265 seconds) 2019-11-11T13:53:52 *** Bosmon3 has joined #fluid-work 2019-11-11T13:58:18 *** danielcho has joined #fluid-work 2019-11-11T14:03:07 *** cindyli1 has joined #fluid-work 2019-11-11T14:03:07 *** cindyli has quit IRC (Read error: Connection reset by peer) 2019-11-11T14:35:34 Hi there cindyli1, I'm sorry you had such lengthy problems finding the source of the corruption! 2019-11-11T14:36:02 You might be glad to know future versions of the framework will be able to guard against problems like this once we make the contents of the model immutable 2019-11-11T14:38:47 *** yzen has joined #fluid-work 2019-11-11T14:40:30 *** Justin_o has joined #fluid-work 2019-11-11T14:42:44 *** alanharnum has joined #fluid-work 2019-11-11T14:44:11 that's great! 2019-11-11T14:44:15 *** cindyli1 is now known as cindyli 2019-11-11T14:48:42 *** clown has joined #fluid-work 2019-11-11T15:35:45 *** Bosmon3 has quit IRC (Ping timeout: 268 seconds) 2019-11-11T15:40:18 *** Bosmon3 has joined #fluid-work 2019-11-11T15:43:18 Bosmon: last week you asked about the FLUID-6426 "can we determine whether these combined selectors are consumed just by the renderer or whether they are also used for general DOM binding during the lifetime of the component?" 2019-11-11T15:44:16 Bosmon: This is one of the panels that gets rendered as a sub panel in the example. https://github.com/fluid-project/infusion/blob/master/examples/framework/preferences/shared/js/panels.js#L58-L101 2019-11-11T15:50:30 interesting that in that case the we use a selectorToIgnore to block the container of the textfieldslider subcomponent from being handed by the renderer 2019-11-11T15:51:11 so I'm assuming that the rebased selectors are only consumed by the renderer 2019-11-11T15:53:34 Bosmon: although I don't think we can guarantee that. For example if a theme picker (e.g. contrast preference) was used as a sub panel, it would make use of the dom binder as well. https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L760-L774 2019-11-11T15:54:26 *** yanachkov__ has quit IRC (Ping timeout: 240 seconds) 2019-11-11T16:07:44 Justin_o - that's pretty awkward 2019-11-11T16:08:21 It suggests that there would be no backward-compatible way of solving the problem, since in the old framework we don't have enough control over the order of instantiation of components 2019-11-11T16:08:58 Perhaps there is no alternative to using a new-style "workflow function" just to resolve the race between the composite panel and its children, just before we delete all this stuff.... 2019-11-11T16:10:24 Bosmon3: what would that entail? 2019-11-11T16:10:41 Bosmon3: also, I'm trying to think of an alternative with the current/old framework. 2019-11-11T16:11:51 Justin_o - actually it probably would not require that, we could probably do it in the new framework with a fairly ordinary kind of expander that issues a fluid.queryIoCSelector to find its children 2019-11-11T16:12:07 *** danayo_ has joined #fluid-work 2019-11-11T16:12:36 If we only had to patch the use of the selectors by the "old renderer" I think it would be fairly easy to just hack it 2019-11-11T16:12:53 Well, I suppose we could hack the DOM binder's selectors too, it isn't going to mind : p 2019-11-11T16:13:16 Bosmon3: I think it already sort of hacks the Dom binder's selectors. we have to reset the Dom binder 2019-11-11T16:13:33 Justin_o - that's true, but that only hacks the container, not the selectors : p 2019-11-11T16:13:40 But yes, perhaps we should do it this way 2019-11-11T16:13:50 https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/Panels.js#L145-L175 2019-11-11T16:14:00 This set of hacks will only heighten the correct impression that the composite panel system is a place where undesirable things go on that we want to eliminate : p 2019-11-11T16:18:51 *** Bosmon3 has quit IRC (Ping timeout: 265 seconds) 2019-11-11T16:23:38 *** alanharnum has quit IRC () 2019-11-11T16:40:00 hahah 2019-11-11T16:40:26 the composite panel system is also very confusing, I'm constantly amazed that it actually works. 2019-11-11T16:40:34 any improvements to it are more than welcome 2019-11-11T16:50:26 fluid-everyone: the latest version of UIO+ is up on the Chrome Web Store. https://chrome.google.com/webstore/detail/ui-options-plus-uio%20/okenndailhmikjjfcnmolpaefecbpaek 2019-11-11T17:13:05 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-11T17:14:44 *** danayo_ has joined #fluid-work 2019-11-11T17:30:09 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-11T17:40:18 *** danayo_ has joined #fluid-work 2019-11-11T18:16:01 cindyli or Justin_o: would one of you be willing to review my SJRK-286 PR? it would be much appreciated :) or anyone else with fluid-project commit rights, really :) https://github.com/fluid-project/sjrk-story-telling/pull/50 2019-11-11T18:22:44 sure, gmoss, i'll review 2019-11-11T18:23:15 thanks cindyli! 2019-11-11T18:26:14 np, gmoss. is it possible for you to fill up the section of "__ in the jira - https://issues.fluidproject.org/browse/SJRK-286? 2019-11-11T18:26:30 cindyli: sure 2019-11-11T18:27:21 gmoss: it would also be helpful to attach a couple of images that can help with reproducing the problem 2019-11-11T18:27:24 thanks 2019-11-11T18:28:39 cindyli: there are some images that satisfy in the testData directory in my PR, would those be sufficient? the manual tests for the imageBlockEditor show instructions now, too. I can just refer to those in the Jira repro steps, would that work for you? 2019-11-11T18:29:19 otherwise I have to describe how to find or produce such an image 2019-11-11T18:29:35 probably why I never filled that step in ;P 2019-11-11T18:30:41 that's totally fine. thanks, gmoss 2019-11-11T18:33:00 cindyli: I have added reproduction instructions :) 2019-11-11T18:33:26 Thanks again for taking a look, let me know if you need any more detail 2019-11-11T18:36:22 sure. thanks 2019-11-11T18:59:22 fluid-everyone: would anyone like to join the blockchain discussion we are having now. I can bring people in remotely. 2019-11-11T19:03:15 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-11T19:05:57 fluid-everyone: if you would like to join, you can join the standup video room. 2019-11-11T19:07:01 Justin_o: Vidyo? Zoom? (it would be ironic if vidyo) 2019-11-11T19:07:10 zoom 2019-11-11T19:07:29 should have specified zoom :) 2019-11-11T19:31:38 *** yzen has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…) 2019-11-11T19:32:10 *** danayo_ has joined #fluid-work 2019-11-11T20:04:19 *** colinclark has joined #fluid-work 2019-11-11T20:41:06 *** cindyli has quit IRC (Quit: Leaving.) 2019-11-11T21:02:05 *** cindyli has joined #fluid-work 2019-11-11T21:09:43 *** colinclark_ has joined #fluid-work 2019-11-11T21:10:17 *** colinclark has quit IRC (Read error: Connection reset by peer) 2019-11-11T21:10:17 *** colinclark_ is now known as colinclark 2019-11-11T21:34:18 *** jhung has quit IRC (Quit: Leaving) 2019-11-11T21:40:30 *** cindyli has quit IRC (Quit: Leaving.) 2019-11-11T22:05:23 *** clown has quit IRC (Quit: Leaving.) 2019-11-11T22:07:22 *** danielcho has left #fluid-work 2019-11-11T22:10:03 *** danayo_ has quit IRC (Quit: danayo_) 2019-11-11T22:46:47 *** the-t-in-rtf has quit IRC (Quit: Leaving.) 2019-11-11T23:43:30 *** colinclark has quit IRC (Quit: colinclark)